Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New debug option to show the blueprint in the streams view #4189

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Nov 9, 2023

What

It's much easier to debug the blueprint if we can see what's going on. Since the blueprint is just another store, we already have decent inspection tools for this.

This just adds a toggle to show the blueprint in the time panel and a bit of extra handling to resolve blueprint entity paths in the selection-panel.

This doesn't handle entity-path-collisions gracefully, but as a debug-only tool that seems like an acceptable trade-off. Eventually we are going to need to track the originating store as part of the selection anyways so this constraint should get resolved at that point.

This will become even more valuable as we migrate from serde-style to arrow-style blueprint components as the data UI will become much more useful.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review November 9, 2023 16:36
@jleibs jleibs added 🟦 blueprint The data that defines our UI 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Nov 9, 2023
@jleibs jleibs force-pushed the jleibs/debug_blueprint_in_timeline branch from 516d9ac to 2a6df18 Compare November 9, 2023 16:41
@jleibs jleibs merged commit 9b9f800 into main Nov 10, 2023
37 of 38 checks passed
@jleibs jleibs deleted the jleibs/debug_blueprint_in_timeline branch November 10, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants